Skip to content

Add CSS to clock module to prevent line breaking of sunrise/sunset information#3816

Merged
khassel merged 11 commits into
MagicMirrorOrg:developfrom
dathbe:patch-2
Jul 2, 2025
Merged

Add CSS to clock module to prevent line breaking of sunrise/sunset information#3816
khassel merged 11 commits into
MagicMirrorOrg:developfrom
dathbe:patch-2

Conversation

@dathbe

@dathbe dathbe commented Jun 23, 2025 •
edited by KristjanESPERANTO
Loading

Copy link
Copy Markdown
Contributor
  1. Base your pull requests against the develop branch.
    Done
  2. Include these infos in the description:
  • Does the pull request solve a related issue?
    No
  • If so, can you reference the issue like this Fixes #<issue_number>?
    N/A
  • What does the pull request accomplish? Use a list if needed.
    With some combinations of sunrise and sunset times (usually when the time till rise/set is >9:59), the information will break across multiple lines. This prevents that by adding CSS.
  • If it includes major visual changes please add screenshots.
    I don't consider it major.
  1. Please run npm run lint:prettier before submitting so that style issues are fixed.
    Done
  2. Don't forget to add an entry about your changes to the CHANGELOG.md file.
    Done

@dathbe dathbe changed the title Patch 2 Add CSS to clock module to prevent line breaking of sunrise/sunset information Jun 23, 2025
@KristjanESPERANTO

KristjanESPERANTO commented Jun 23, 2025

Copy link
Copy Markdown
Collaborator

Looks good, but as there is not an open issue: Could you please provide a screenshot from before and one from after your changes?

@dathbe

dathbe commented Jun 23, 2025

Copy link
Copy Markdown
Contributor Author

Before:
before

After:
after

@dathbe

dathbe commented Jun 23, 2025

Copy link
Copy Markdown
Contributor Author

After spacing cleaned up:

after2

rejas
rejas requested changes Jun 24, 2025
View reviewed changes

@rejas rejas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup. some paddings can be done more elegantly though.

Comment thread modules/default/clock/clock_styles.css Outdated
Comment thread modules/default/clock/clock_styles.css Outdated
Comment thread modules/default/clock/clock_styles.css Outdated
@dathbe

dathbe commented Jun 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I've simplified it, but I think the padding-top for .sun and .moon is still needed because adding flex to the digital class completely rearranges the elements of the module.

@khassel

khassel commented Jun 29, 2025

Copy link
Copy Markdown
Collaborator

@rejas can you please re-review?

@rejas

rejas commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator

sorry for not doing it before the release. i took the liberty of adding my line of thought and code to your PR. what do you think about it @dathbe ?

@dathbe

dathbe commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

I haven't tested it yet, but assuming someone has I don't have any problem with your implementation of the 3px gap.

@rejas rejas requested a review from khassel July 1, 2025 20:40
khassel
khassel reviewed Jul 1, 2025
View reviewed changes
Comment thread CHANGELOG.md Outdated
@dathbe

dathbe commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

Done

@khassel

khassel commented Jul 2, 2025

Copy link
Copy Markdown
Collaborator

Done

sorry for being not clear enough, I wanted @rejas to fix this because he asked for review and he missed the release ;)

But anyway, thanks!

@khassel khassel merged commit 3a2a52c into MagicMirrorOrg:develop Jul 2, 2025
9 checks passed
@dathbe dathbe deleted the patch-2 branch July 2, 2025 22:21
@KristjanESPERANTO KristjanESPERANTO mentioned this pull request Sep 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khassel khassel khassel left review comments
@rejas rejas rejas requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dathbe @KristjanESPERANTO @khassel @rejas